Add missing polls LLC operations #5966

VelikovPetar · 2025-10-15T09:26:01Z

🎯 Goal

Implements poll and poll options management operations on the LLC.
Added:

ChatClient.getPoll(pollId: String)
ChatClient.partialUpdatePoll(pollId: String, set: Map<String, Any>, unset: List<String>)
ChatClient.createPollOption(pollId: String, option: CreatePollOptionRequest)
ChatClient.updatePollOption(pollId: String, option: UpdatePollOptionRequest)
ChatClient.deletePollOption(pollId: String, optionId: String)
ChatClient.queryPollVotes(pollId: String, filter: FilterObject?, limit: Int?, next: String?, sort: QuerySorter<Vote>?)
ChatClient.queryPolls(filter: FilterObject?, limit: Int?, next: String?, sort: QuerySorter<Poll>?)
PollConfig (used in ChatClient.sendPoll) constructor which accepts extra data for the poll and the poll options

Deprecated:

PollConfig constructor without extra data
ChatClient.suggestPollOption in favour of ChatClient.createPollOption

Resolves: https://linear.app/stream/issue/AND-793/align-llc-polls-api
Docs PR: https://github.com/GetStream/docs-content/pull/690

🛠 Implementation details

Implements the missing poll-related operations, alongside the Retrofit APIs, network/domain models, and offline storage updates. Replaces the usage of the deprecated methods with the new ones.

Resolves:
https://linear.app/stream/issue/AND-793/align-llc-polls-api

🎨 UI Changes

NA

🧪 Testing

Standard poll testing:

Create a poll (with different options)
Add / Change / Delete votes
Add comment
Create option
Close poll
Ensure everything works fine

For the new endpoints - they are not linked to the UI, so you need to manually call them and verify they return the expected results.

# Conflicts: # stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/MoshiChatApi.kt # stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/mapping/DomainMapping.kt # stream-chat-android-client/src/test/java/io/getstream/chat/android/client/Mother.kt

github-actions · 2025-10-15T09:26:39Z

DB Entities have been updated. Do we need to upgrade DB Version?
Modified Entities :

stream-chat-android-offline/src/main/java/io/getstream/chat/android/offline/repository/domain/message/internal/Poll.kt

github-actions · 2025-10-15T09:32:20Z

SDK Size Comparison 📏

SDK	Before	After	Difference	Status
stream-chat-android-client	3.23 MB	3.24 MB	0.01 MB	🟢
stream-chat-android-offline	3.45 MB	3.46 MB	0.01 MB	🟢
stream-chat-android-ui-components	10.54 MB	10.55 MB	0.01 MB	🟢
stream-chat-android-compose	12.76 MB	12.78 MB	0.02 MB	🟢

# Conflicts: # stream-chat-android-client/src/main/java/io/getstream/chat/android/client/ChatClient.kt

Copilot

Pull Request Overview

This PR implements missing polls LLC (Low Level Client) operations to provide comprehensive poll and poll option management capabilities. The PR adds several new endpoints while maintaining backward compatibility through deprecation warnings.

Key changes include:

Addition of poll CRUD operations including get, partial update, and query endpoints
Implementation of poll option lifecycle management (create, update, delete)
Enhanced poll creation with support for extra data on both polls and options
Proper offline storage updates and network/domain model extensions

Reviewed Changes

Copilot reviewed 49 out of 49 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
stream-chat-android-ui-components/.../CreatePollViewModel.kt	Updates poll creation to use PollOption objects instead of plain strings
stream-chat-android-ui-common/.../MessageListController.kt	Replaces deprecated suggestPollOption with createPollOption
stream-chat-android-previewdata/.../PreviewPollData.kt	Adds missing poll properties for preview data consistency
stream-chat-android-offline/.../PollsMapperTest.kt	New comprehensive test suite for poll entity mapping
stream-chat-android-offline/.../PollsMapper.kt	New mapper for poll entity conversions with proper domain mapping
stream-chat-android-offline/.../Poll.kt	Enhanced poll entity with additional fields for complete data storage
stream-chat-android-offline/.../MessageMapper.kt	Removes duplicate poll mapping code in favor of dedicated mapper
stream-chat-android-offline/.../ChatDatabase.kt	Database schema version bump to accommodate new poll fields
stream-chat-android-core/.../Mother.kt	Updates test data factory to include new poll properties
stream-chat-android-core/.../Poll.kt	Enhanced poll models with extra data support and comparable field providers
stream-chat-android-client/.../ChatClient.kt	Adds comprehensive poll management API methods with proper deprecation

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

...hat-android-client/src/main/java/io/getstream/chat/android/client/api/models/PollRequests.kt

…roid/client/api/models/PollRequests.kt Co-authored-by: Copilot <[email protected]>

# Conflicts: # CHANGELOG.md

sonarqubecloud · 2025-11-03T11:36:48Z

Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

andremion · 2025-11-06T09:28:40Z

...-android-client/src/main/java/io/getstream/chat/android/client/api2/mapping/DomainMapping.kt

    }

+    /**
+     * Transforms [DownstreamPushPreferenceDto] to [PushPreference].


Suggested change

* Transforms [DownstreamPushPreferenceDto] to [PushPreference].

* Transforms [QueryPollVotesResponse] to [QueryPollVotesResult].

andremion · 2025-11-06T10:18:59Z

stream-chat-android-client/src/main/java/io/getstream/chat/android/client/ChatClient.kt

        pollId: String,
        vote: Vote,
    ): Call<Vote> {
        return api.removePollVote(messageId, pollId, vote.id)


What do you think about creating:

removePollVote( messageId: String, pollId: String, voteId: String, ):

and deprecate:

removePollVote( messageId: String, pollId: String, vote: Vote, ):

?
So that would be align with the specs https://www.notion.so/stream-wiki/Polls-c53f9695fb4e4d9083e5b6b2c49017fd#79a88ba6da7e4fbe8b7e05ce119ba1bc

Good point, I can do that!

andremion · 2025-11-06T10:22:43Z

stream-chat-android-client/src/main/java/io/getstream/chat/android/client/ChatClient.kt

+     * @return Executable async [Call] responsible for updating a poll.
+     */
+    @CheckResult
+    public fun partialUpdatePoll(


What about the full update poll?

https://www.notion.so/stream-wiki/Polls-c53f9695fb4e4d9083e5b6b2c49017fd?pvs=97&qid=1:147f7b66-a0d0-4513-933b-b266a4aabd8e:1#db2aec6dc74a49bb8a0e221d38991465

I will add it!

andremion · 2025-11-06T10:32:08Z

stream-chat-android-client/src/main/java/io/getstream/chat/android/client/ChatClient.kt

+    @CheckResult
+    public fun createPollOption(
+        pollId: String,
+        option: CreatePollOptionRequest,


Since this is a public API, what do you think about removing the Request from the data class name?
Maybe also consider reusing the PollOption model.
The id could be introduced to PollOption as optional, so it could be reused by create and update, instead of using CreatePollOptionRequest and UpdatePollOptionRequest models

I was actually considering to use the PollOption, but I wasn't; sure about defining it as:

data class PollOption(val id: String? = null)

But I was worried about being a bit confusing for usars. Let me try again to see how it would affect the API, and I will get back to you.

VelikovPetar added 10 commits October 6, 2025 15:32

Add missing arguments to CreatePoll.

0badf78

Add getPoll operation.

1d5c0ae

Add partialUpdatePoll operation.

feecf44

Rework close poll to use partialUpdatePoll internally.

b0bb392

Add createPollOption and updatePollOption.

baacd7d

Add deletePollOption.

b08a0f7

Add deletePollOption.

77d1683

Add QueryPolls.

1787a28

Add QueryPollVotes.

06bec1e

VelikovPetar added 8 commits October 15, 2025 11:36

Deprecate `ChatClient.suggestPollOption.

51d3f8d

Bump ChatDatabase version.

4a3740b

Update PollConfig to prevent breaking changes.

fcba65c

Re-organize ChatClient poll operations.

4ac8a27

Merge branch 'develop' into feature/align-polls-api

6253a3c

# Conflicts: # stream-chat-android-client/src/main/java/io/getstream/chat/android/client/ChatClient.kt

Update CHANGELOG.md.

63bc329

Fix tests.

b7c9efc

Improve test coverage.

d677a6c

VelikovPetar requested a review from Copilot October 20, 2025 12:19

VelikovPetar marked this pull request as ready for review October 20, 2025 12:19

VelikovPetar requested a review from a team as a code owner October 20, 2025 12:19

Copilot AI reviewed Oct 20, 2025

View reviewed changes

...hat-android-client/src/main/java/io/getstream/chat/android/client/api/models/PollRequests.kt Outdated Show resolved Hide resolved

VelikovPetar and others added 6 commits October 20, 2025 14:44

Update stream-chat-android-client/src/main/java/io/getstream/chat/and…

818740d

…roid/client/api/models/PollRequests.kt Co-authored-by: Copilot <[email protected]>

Merge branch 'develop' into feature/align-polls-api

5fb9862

# Conflicts: # CHANGELOG.md

Improve test coverage.

3960e16

Merge branch 'develop' into feature/align-polls-api

92cb2ac

Bump DB version.

42ec998

Merge branch 'develop' into feature/align-polls-api

fe4d05b

# Conflicts: # CHANGELOG.md

Merge branch 'develop' into feature/align-polls-api

b3ba595

# Conflicts: # CHANGELOG.md

andremion reviewed Nov 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add missing polls LLC operations #5966

Add missing polls LLC operations #5966

Uh oh!

VelikovPetar commented Oct 15, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 15, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Nov 3, 2025

Uh oh!

andremion Nov 6, 2025

Uh oh!

andremion Nov 6, 2025

Uh oh!

VelikovPetar Nov 6, 2025

Uh oh!

andremion Nov 6, 2025

Uh oh!

VelikovPetar Nov 6, 2025

Uh oh!

andremion Nov 6, 2025

Uh oh!

VelikovPetar Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	* Transforms [DownstreamPushPreferenceDto] to [PushPreference].
	* Transforms [QueryPollVotesResponse] to [QueryPollVotesResult].

Add missing polls LLC operations #5966

Are you sure you want to change the base?

Add missing polls LLC operations #5966

Uh oh!

Conversation

VelikovPetar commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Goal

🛠 Implementation details

🎨 UI Changes

🧪 Testing

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK Size Comparison 📏

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

sonarqubecloud bot commented Nov 3, 2025

Quality Gate passed

Uh oh!

andremion Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

andremion Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

VelikovPetar Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

andremion Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

VelikovPetar Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

andremion Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

VelikovPetar Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

VelikovPetar commented Oct 15, 2025 •

edited

Loading

github-actions bot commented Oct 15, 2025 •

edited

Loading